-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pid_longitudinal_controller): add new slope compensation mode trajectory_goal_adaptive #9705
Merged
yuki-takagi-66
merged 4 commits into
autowarefoundation:main
from
tier4:takagi/slope/add-slope-comp-logic-trajectory_goal_adaptive
Dec 20, 2024
Merged
feat(pid_longitudinal_controller): add new slope compensation mode trajectory_goal_adaptive #9705
yuki-takagi-66
merged 4 commits into
autowarefoundation:main
from
tier4:takagi/slope/add-slope-comp-logic-trajectory_goal_adaptive
Dec 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yuki-takagi-66 <[email protected]>
Signed-off-by: yuki-takagi-66 <[email protected]>
github-actions
bot
added
the
component:control
Vehicle control algorithms and mechanisms. (auto-assigned)
label
Dec 20, 2024
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
yuki-takagi-66
changed the title
feat(pid_longitudinal_cotroller):
feat(pid_longitudinal_controller): add new slope compensation mode trajectory_goal_adaptive
Dec 20, 2024
Signed-off-by: yuki-takagi-66 <[email protected]>
Signed-off-by: yuki-takagi-66 <[email protected]>
github-actions
bot
added
the
type:documentation
Creating or refining documentation. (auto-assigned)
label
Dec 20, 2024
yuki-takagi-66
requested review from
soblin,
TakaHoribe and
takayuki5168
as code owners
December 20, 2024 09:54
yuki-takagi-66
added
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
run:deploy-docs
Mark for deploy-docs action generation. (used-by-ci)
labels
Dec 20, 2024
takayuki5168
approved these changes
Dec 20, 2024
yuki-takagi-66
merged commit Dec 20, 2024
4c03b8d
into
autowarefoundation:main
45 of 55 checks passed
yuki-takagi-66
deleted the
takagi/slope/add-slope-comp-logic-trajectory_goal_adaptive
branch
December 20, 2024 10:32
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Dec 25, 2024
…ajectory_goal_adaptive (autowarefoundation#9705) Signed-off-by: yuki-takagi-66 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:control
Vehicle control algorithms and mechanisms. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
run:deploy-docs
Mark for deploy-docs action generation. (used-by-ci)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR provides a new compensation mode trajectory_goal_adaptive.
Road slope estimation from trajectory is works well only if the rest trajectory length is longer than wheel base length.
Only this situation, the new mode use pose estimation ptich.
Related links
autowarefoundation/autoware_launch#1288
How was this PR tested?
psim and tier4 scenario tests
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.